Skip to content

Comments

[AIRFLOW-5504] Improve project_id in GCP Kubernetes Hook#6126

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:fix-gke-support-project-id
Sep 16, 2019
Merged

[AIRFLOW-5504] Improve project_id in GCP Kubernetes Hook#6126
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:fix-gke-support-project-id

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Sep 16, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5504
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added k8s provider:google Google (including GCP) related issues labels Sep 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #6126 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6126      +/-   ##
=========================================
- Coverage   80.11%   80.1%   -0.01%     
=========================================
  Files         607     607              
  Lines       34902   34902              
=========================================
- Hits        27961   27959       -2     
- Misses       6941    6943       +2
Impacted Files Coverage Δ
airflow/gcp/hooks/kubernetes_engine.py 95.89% <100%> (ø) ⬆️
airflow/jobs/local_task_job.py 85% <0%> (-5%) ⬇️
airflow/jobs/scheduler_job.py 74.28% <0%> (-0.31%) ⬇️
airflow/utils/dag_processing.py 58.98% <0%> (+0.18%) ⬆️
airflow/models/taskinstance.py 93.72% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533086e...3a9b616. Read the comment docs.

@potiuk potiuk merged commit 7e55600 into apache:master Sep 16, 2019
@TobKed TobKed deleted the fix-gke-support-project-id branch September 19, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants