Skip to content

Conversation

@dheerajturaga
Copy link
Member

keyring is a core dependency of airflow-ctl, but it requires a backend
to function. On desktop systems a native backend (macOS Keychain, GNOME
Keyring, Windows Credential Vault) is available, but in containerized
environments like the breeze CI image none exists. keyrings.alt provides
a file-based fallback backend for exactly this case.

Moving keyrings.alt to core dependencies is safe: keyring's backend
selection is priority-based, so native backends are always preferred when
available. keyrings.alt only kicks in as a fallback on systems without
one.

  keyring is a core dependency of airflow-ctl, but it requires a backend
  to function. On desktop systems a native backend (macOS Keychain, GNOME
  Keyring, Windows Credential Vault) is available, but in containerized
  environments like the breeze CI image none exists. keyrings.alt provides
  a file-based fallback backend for exactly this case.

  Moving keyrings.alt to core dependencies is safe: keyring's backend
  selection is priority-based, so native backends are always preferred when
  available. keyrings.alt only kicks in as a fallback on systems without
  one.
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think we shouldn't add this as a dependency as it is not recommended for production, only for development. We should not provide one. The user should select it most OS have it's own and IT teams manages it for them in bigger use cases
We can consider creating a docker image which then we can consider how to handle this use case

@dheerajturaga
Copy link
Member Author

Thanks for the PR! I think we shouldn't add this as a dependency as it is not recommended for production, only for development. We should not provide one. The user should select it most OS have it's own and IT teams manages it for them in bigger use cases
We can consider creating a docker image which then we can consider how to handle this use case

@bugraoz93 in that case, should we add airflow-ctl[dev] to Docker.ci instead?

@bugraoz93
Copy link
Contributor

Thanks for the PR! I think we shouldn't add this as a dependency as it is not recommended for production, only for development. We should not provide one. The user should select it most OS have it's own and IT teams manages it for them in bigger use cases
We can consider creating a docker image which then we can consider how to handle this use case

@bugraoz93 in that case, should we add airflow-ctl[dev] to Docker.ci instead?

I meant separate small image without even have Airflow core or any other distributions. This deserves a discussion thread and some kind of lazy consensus/voting to be aligned. We can still add airflow-ctl[dev] in ci image to, that is not the one released or running in our local breeze envs. So adding like that make sense to eliminate for development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants