AIP-67 Fix incomplete workload payloads in Celery executor integration test #61332
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n test The test constructed ExecuteTask and TaskInstance via model_construct(), which bypasses Pydantic validation. Fields added or made required by apache#50825 (dag_version_id, pool_slots) and inherited from BaseDagBundleWorkload (token, dag_rel_path, bundle_info, log_path) were missing. This went unnoticed until apache#60675 changed task dispatch to run in ProcessPoolExecutor subprocesses where mock patches don't apply, causing the real execute_workload (with full schema validation) to run on the worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test constructed ExecuteTask and TaskInstance via model_construct(),
which bypasses Pydantic validation. Fields added or made required by
#50825 (dag_version_id, pool_slots) and inherited from BaseDagBundleWorkload
(token, dag_rel_path, bundle_info, log_path) were missing. This went
unnoticed until #60675 changed task dispatch to run in ProcessPoolExecutor
subprocesses where mock patches don't apply, causing the real
execute_workload (with full schema validation) to run on the worker.
Was generative AI tooling used to co-author this PR?
ClaudeCode