Fix(Amazon): Restore wait_policy in EmrCreateJobFlowOperator#61373
Closed
dv-gorasiya wants to merge 2 commits intoapache:mainfrom
Closed
Fix(Amazon): Restore wait_policy in EmrCreateJobFlowOperator#61373dv-gorasiya wants to merge 2 commits intoapache:mainfrom
dv-gorasiya wants to merge 2 commits intoapache:mainfrom
Conversation
This restores the ability to specify a WaitPolicy (e.g. WAIT_FOR_STEPS_COMPLETION) instead of forcing the default 'running' state check. Closes apache#61180.
Verifies that the specified wait_policy is respected and the deprecated warning is removed.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Contributor
|
Seems to be a duplicate of https://github.com/apache/airflow/pull/61195/changes? |
Author
|
Closing in favor of #61195, which covers the same fix and includes better test coverage and deferrable support. Thanks @phanikumv for pointing it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the functionality of the
wait_policyparameter inEmrCreateJobFlowOperator.Previously,
wait_policywas deprecated and ignored in favor of a hardcoded 'running' state check whenwait_for_completionwas True.This change allows users to explicitly specify policies like
WAIT_FOR_STEPS_COMPLETION(to wait for cluster termination) while maintaining backward compatibility (impliedwait_for_completion=True).Related Issue
Closes #61180
Tests
Added
test_execute_with_wait_policyto verify the correct waiter is used.Removed
test_wait_policy_deprecation_warningas the parameter is no longer deprecated.