[v3-1-test] Add empty version suffix when preparing distributions by PMC members (#61352)#61386
Draft
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Draft
[v3-1-test] Add empty version suffix when preparing distributions by PMC members (#61352)#61386github-actions[bot] wants to merge 1 commit intov3-1-testfrom
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Conversation
…PMC members (#61352) If VERSION_SUFFIX is exported in the current terminal, it can be accidentally used as `--version-suffix` by distribution preparation commands - which in case of the PMC verification might cause preparing of `PyPI` variants of the distributions, not the `SVN` ones (without RC suffix). This PR updates the relevant commands to override the suffix with empty suffix - which also is an explicit signal that this is intended. (cherry picked from commit 9a38e8c) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If VERSION_SUFFIX is exported in the current terminal, it can be
accidentally used as
--version-suffixby distribution preparationcommands - which in case of the PMC verification might cause preparing
of
PyPIvariants of the distributions, not theSVNones (withoutRC suffix). This PR updates the relevant commands to override the
suffix with empty suffix - which also is an explicit signal that
this is intended.
(cherry picked from commit 9a38e8c)
Co-authored-by: Jarek Potiuk jarek@potiuk.com