Add exception test for GenAICountTokensOperator #61391
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Contributor
SameerMesiah97
left a comment
SameerMesiah97
left a comment
There was a problem hiding this comment.
Looks good to me. Just 2 tiny suggestions for extra polish to make the test more explicit.
providers/google/tests/unit/google/cloud/operators/test_gen_ai.py
Outdated
Show resolved
Hide resolved
providers/google/tests/unit/google/cloud/operators/test_gen_ai.py
Outdated
Show resolved
Hide resolved
- Rename test_execute_exception to test_execute_propagates_client_error - Update docstring to specify ClientError instead of generic exceptions
Author
|
Applied suggestions: renamed test method and updated docstring as suggested. Thanks @SameerMesiah97! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exception tests for GenAICountTokensOperator as part of issue #61261. The test verifies that exceptions raised by the hook are properly propagated.
Operator selected: GenAICountTokensOperator (as commented on the issue).
Test covers ClientError exception from the google.genai.errors module.