Deprecate BackfillDetails and use DagAcccessEntity.Run for backfill p… #61400
+73
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
added
the
backport-to-v3-1-test
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
rawwar,
shubhamraj-git and
vincbeck
as code owners
pierrejeambrun
commented
Feb 3, 2026
vincbeck
reviewed
Feb 3, 2026
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/auth/managers/models/resource_details.py
Outdated
Show resolved
Hide resolved
vincbeck
reviewed
Feb 3, 2026
| @@ -146,14 +148,19 @@ async def get_user( | |||
|
|
|||
|
|
|||
| def requires_access_dag( | |||
Contributor
There was a problem hiding this comment.
Can you cover these changes in unit tests as well?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #60948
Deprecate
is_authorized_backfillandBackfillDetailsin favor ofDagAccessEntity.Run.Basically this will allow dag access level control on backfills, a backfill is always attached to a Dag, and shouldn't probably have been a sub
DagAccessEntityin the auth model. We chose to simply re-use the existingDagAccessEntity.Runinstead of creating a new one because 'creating a backfill' is basically similar to creating multiple dag runs. (A user withCan create on Dag Runscan simulate a backfill by triggering as many dag runs as needed with the appropriate conf and data).From now on permissions granted on
DagRunswill also allow similar permissions on 'Backfills' of a specific dag id.Note: I plan a follow up PR for the providers.