fix query to prevent long query when asset count is too much#61519
Open
wjddn279 wants to merge 1 commit intoapache:mainfrom
Open
fix query to prevent long query when asset count is too much#61519wjddn279 wants to merge 1 commit intoapache:mainfrom
wjddn279 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #61453
Why?
There was an issue where IN operations on a large number of rows in the assets table caused long-running queries.
This commit fixes that issue.
How?
While we could improve this using CTEs, joins, etc., it would make the code messy and introduce side effects such as having to execute the orphan status query multiple times. Therefore, I decided to minimize (eliminate) the IN operations.
The rationale for this logic being equivalent to the original logic is as follows:
asset_reference_querygroups by the primary key of assets, so it is unique.orphanedis True and False are complements of each other.self._orphan_unreferenced_assets, orphaned rows from active_assets are deleted.self._activate_referenced_assetsis unnecessary.More?
Nevertheless, if there are too many orphaned assets, performance degradation may still occur at this point.
If the number of orphaned assets is large (above a certain threshold), it would be good to display a DAG warning.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.