Add nested class support to import_string function#61606
Open
MrEhsanEllahi wants to merge 1 commit intoapache:mainfrom
Open
Add nested class support to import_string function#61606MrEhsanEllahi wants to merge 1 commit intoapache:mainfrom
MrEhsanEllahi wants to merge 1 commit intoapache:mainfrom
Conversation
106ecc9 to
bccd14f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement support for importing nested classes in the
import_stringfunction, removing the limitation documented in the TODO comment.Problem
The
import_stringfunction had a TODO comment indicating it only worked for top-level classes:# TODO: Add support for nested classes. Currently, it only works for top-level classes.Attempting to import paths like
mymodule.OuterClass.InnerClass.DeepClasswould fail withModuleNotFoundError.Solution
Implemented a backtracking algorithm that:
ModuleNotFoundErrororImportError, backtracks one levelExample
Changes Made
File Modified:
shared/module_loading/src/airflow_shared/module_loading/__init__.pyChanges:
import_stringfunctionModuleNotFoundErrorandImportErrorTesting
test_module_loading.pypassTest results: 22/22 passed (100%)
Type of Change
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.