-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Skip SVN operations in CI environment #61660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not a bad idea
|
Breeze unit tests will need fixing though |
ac0966e to
949f833
Compare
Yeah. My favourite AI was on it :) |
8902c9a to
a3929b2
Compare
|
Hey @shahar1 -> also added a few small things:
So instead when "real" SVN is used (locally) - it checks which version is available in SVN for airflow and task-sdk - and uses the revision it finds. For CI running, it uses some "simulated" versions and creates the folder. |
|
It's been way more than initially anticipated :D |
a3929b2 to
35c4fa9
Compare
Great, thanks for all of that! |
35c4fa9 to
a94f55c
Compare
The release candidate commands were failing in CI because SVN operations require credentials and network access to the ASF SVN repository. This change detects when running in CI (via CI environment variable) and simulates SVN operations instead of executing them: - svn checkout: creates empty directory structure - svn mkdir: uses regular mkdir - svn add/commit/rm: prints simulation messages This allows the release candidate workflow to be validated in CI without requiring SVN access, while preserving full functionality in production.
a94f55c to
a33ae93
Compare
Claude was helpful :) |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 5953b82 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
The release candidate commands were failing in CI because SVN operations require credentials and network access to the ASF SVN repository.
This change detects when running in CI (via CI environment variable) and simulates SVN operations instead of executing them:
This allows the release candidate workflow to be validated in CI without requiring SVN access, while preserving full functionality in production.
Was generative AI tooling used to co-author this PR?
Generated-by: Copilot with auto model following the guidelines
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.