-
Notifications
You must be signed in to change notification settings - Fork 16.5k
i18n(Ko): add missing translations (Feb 11) #61762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I have a quick question about this part.
| "dagProcessorJob": "DagProcessorJob", | ||
| "schedulerJob": "SchedulerJob", | ||
| "triggererJob": "TriggererJob" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is currently in English. Would it be better to translate it into Korean?
I’ve also been thinking about our translation guidelines and would appreciate your thoughts on this.
So far, I’ve been transliterating terms like “triggerer” (e.g., “트리거러”) for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Since prior translations already follow this approach, it makes sense to stay consistent for now until we revisit the overall convention.
@1wos Also, thanks for volunteering and contributing to the Korean translation! Much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review and the helpful suggestion!
I've updated the translations to follow the existing transliteration convention.
Added missing Korean Translations
Please review this translations.
/cc @choo121600 @kgw7401 @onestn @noeunkim
Before
After
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.