Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 11, 2026

Passing None is absolutely fine for dataset alias and raising a warning when it happens is not a good idea.

Fixes #51194


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Passing None is absolutely fine for dataset alias and raising
a warning when it happens is not a good idea.

Fixes apache#51194
@potiuk potiuk requested review from Dev-iL, Lee-W and uranusjr February 11, 2026 20:33
@potiuk potiuk added this to the Airflow 2.11.1 milestone Feb 11, 2026
Copy link
Collaborator

@Dev-iL Dev-iL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, where did you dig up that issue? 2.11.1 has been quite a while in the making...
Of course I approve - it's exactly how I thought it should be solved 👍

@potiuk
Copy link
Member Author

potiuk commented Feb 12, 2026

Heh, where did you dig up that issue?

Had 2.11.1 milestone assigned :)

@potiuk potiuk merged commit 3a8464a into apache:v2-11-test Feb 12, 2026
41 of 42 checks passed
@potiuk potiuk deleted the remove-alias-warning-for-strings branch February 12, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants