Skip to content

[AIRFLOW-XXX] Add ASF integration tables#6188

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:integration-rst-2
Sep 26, 2019
Merged

[AIRFLOW-XXX] Add ASF integration tables#6188
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:integration-rst-2

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Sep 26, 2019

This PR is one of a series about restructuring integration.rst
https://issues.apache.org/jira/browse/AIRFLOW-5431


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @mik-laj 👍 !

@mik-laj mik-laj merged commit d0ebbd5 into apache:master Sep 26, 2019
@mik-laj
Copy link
Member Author

mik-laj commented Sep 26, 2019

Docs build pass, so I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants