Remove global variables in airflow.settings#61917
Draft
jscheffl wants to merge 3 commits intoapache:mainfrom
Draft
Remove global variables in airflow.settings#61917jscheffl wants to merge 3 commits intoapache:mainfrom
jscheffl wants to merge 3 commits intoapache:mainfrom
Conversation
7852973 to
6aee6ee
Compare
6aee6ee to
9925fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small increment to remove global statements for PR #58116 - an alternative approach to #61356.
This removes global statements from settings.py where the a lot of state was hold in variables used with global and then a lot of code way relying to access these globals. Is a like a public interface and refactoring would be needed.
globalis evil.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.