Skip to content

[AIRFLOW-XXX] Add protocol operators and hooks table#6193

Merged
mik-laj merged 4 commits intoapache:masterfrom
PolideaInternal:integration-rst-7
Sep 28, 2019
Merged

[AIRFLOW-XXX] Add protocol operators and hooks table#6193
mik-laj merged 4 commits intoapache:masterfrom
PolideaInternal:integration-rst-7

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Sep 26, 2019

This PR is one of a series about restructuring integration.rst
https://issues.apache.org/jira/browse/AIRFLOW-5431


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj force-pushed the integration-rst-7 branch 2 times, most recently from 86d2789 to 51bb7f7 Compare September 26, 2019 13:20
@mik-laj mik-laj changed the title [AIRFLOW-XXX][depends on #6192] Add protocol operators and hooks table [AIRFLOW-XXX][depends on #6191] Add protocol operators and hooks table Sep 26, 2019
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check again after the other one is merged :)

@mik-laj mik-laj requested review from feluelle and potiuk September 28, 2019 04:16
@codecov-io
Copy link

codecov-io commented Sep 28, 2019

Codecov Report

Merging #6193 into master will decrease coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6193      +/-   ##
==========================================
- Coverage   80.02%   79.05%   -0.97%     
==========================================
  Files         610      610              
  Lines       35176    35176              
==========================================
- Hits        28150    27809     -341     
- Misses       7026     7367     +341
Impacted Files Coverage Δ
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
airflow/executors/celery_executor.py 40.74% <0%> (-35.56%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2350b2f...a5cec6e. Read the comment docs.

@mik-laj
Copy link
Member Author

mik-laj commented Sep 28, 2019

Rebased. Now I can start working on transfer operators for protocol, services and services.

@mik-laj mik-laj changed the title [AIRFLOW-XXX][depends on #6191] Add protocol operators and hooks table [AIRFLOW-XXX] Add protocol operators and hooks table Sep 28, 2019
@mik-laj mik-laj merged commit bfe0ace into apache:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants