Add validation for missing host and cluster/workgroup identifier in aws iam token retrieval#61965
Open
justinpakzad wants to merge 3 commits intoapache:mainfrom
Open
Conversation
justinpakzad
force-pushed
the
fix/postgres-hook-host-clusid-none-handling
branch
from
f03684e to
99f9fc4
Compare
Contributor
Author
|
Seems to be an unrelated test that's failing. |
Contributor
SameerMesiah97
left a comment
SameerMesiah97
left a comment
There was a problem hiding this comment.
I have left a few comments.
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
Outdated
Show resolved
Hide resolved
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
Outdated
Show resolved
Hide resolved
justinpakzad
force-pushed
the
fix/postgres-hook-host-clusid-none-handling
branch
from
99f9fc4 to
1e5d2a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation/handling in the PostgresHook
get_aws_iam_token()method for situations where host and cluster-identifier/workgroup-name are not provided. Added additional test cases as well.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.