Allow null start_date in DagRun Pydantic model to fix rerun regression (#61381)#61981
Open
v4xsh wants to merge 1 commit intoapache:mainfrom
Open
Allow null start_date in DagRun Pydantic model to fix rerun regression (#61381)#61981v4xsh wants to merge 1 commit intoapache:mainfrom
v4xsh wants to merge 1 commit intoapache:mainfrom
Conversation
Allow DagRun.start_date to be optional to support cleared and legacy DagRuns. Add regression tests to ensure scheduler accepts NULL start_date.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Pydantic ValidationError when rerunning cleared DagRun
Closes #61381
Problem
When rerunning or clearing DAG runs (especially those created in older Airflow versions), the scheduler may raise:
This occurs because the Pydantic
DagRunmodel requiredstart_dateto be a non-null datetime, while cleared or queued DAG runs can legitimately havestart_date=Nonein the database.Root Cause
The Pydantic
DagRunmodel in:did not allow
start_date=None, causing aValidationErrorwhen constructingDagRunContextduring scheduling.Changes Made
1️⃣ Allow
start_dateto be nullableThis aligns the Pydantic model with:
2️⃣ Add default for
partition_keyEnsures consistent optional behavior.
Tests Added
New test file:
Includes:
test_dagrun_model_accepts_null_start_datetest_dagrun_context_accepts_null_start_dateThese verify:
DagRunmodel acceptsstart_date=NoneDagRunContextcan be constructed without raisingValidationErrorResult