fix(ui): Graph View layout broken for non-LR orientations with TaskGroups#62144
Open
rsilvestre wants to merge 1 commit intoapache:mainfrom
Open
fix(ui): Graph View layout broken for non-LR orientations with TaskGroups#62144rsilvestre wants to merge 1 commit intoapache:mainfrom
rsilvestre wants to merge 1 commit intoapache:mainfrom
Conversation
The `elk.portConstraints: "FIXED_SIDE"` layout option breaks ELK.js layout for non-LR orientations (TB, BT, RL) when TaskGroups are present, causing nodes to spread horizontally and overlap. This is a regression introduced between 3.0.6 and 3.1.x. Conditionally apply the constraint only for RIGHT (LR) direction, restoring correct layout behavior for all orientations. Closes: apache#61384
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elk.portConstraints: "FIXED_SIDE"layout option is now conditionally applied only for RIGHT (LR) direction, as it causes ELK.js to incorrectly spread nodes horizontally for other orientationsRoot Cause
The
elk.portConstraints: "FIXED_SIDE"option was applied unconditionally to both open TaskGroup nodes and individual task nodes. This constraint works correctly for LR layouts but breaks the ELK.js layout algorithm for TB, BT, and RL orientations when TaskGroups are present.Test plan
Closes #61384