Skip to content

fix(providers/fab): restore OAuth callback route exposure#62150

Closed
tschroeder-zendesk wants to merge 1 commit intoapache:mainfrom
tschroeder-zendesk:fix/fab-oauth-authorized-endpoint-3-3-0
Closed

fix(providers/fab): restore OAuth callback route exposure#62150
tschroeder-zendesk wants to merge 1 commit intoapache:mainfrom
tschroeder-zendesk:fix/fab-oauth-authorized-endpoint-3-3-0

Conversation

@tschroeder-zendesk
Copy link

@tschroeder-zendesk tschroeder-zendesk commented Feb 18, 2026

Restore OAuth callback route registration on CustomAuthOAuthView.

CustomAuthOAuthView.oauth_authorized overrides FAB's AuthOAuthView.oauth_authorized, but without re-applying the @expose("/oauth-authorized/<provider>") decorator the callback endpoint is not registered on the custom view. This breaks URL generation for CustomAuthOAuthView.oauth_authorized during OAuth login.

This PR re-adds the route decorator and includes a regression unit test asserting the callback route remains exposed.

Fixes #62028

Testing

  • source .venv/bin/activate && ruff check providers/fab/src/airflow/providers/fab/auth_manager/views/auth_oauth.py providers/fab/tests/unit/fab/auth_manager/views/test_auth_oauth.py
  • breeze run --python 3.12 --platform linux/amd64 --tty disabled --skip-image-upgrade-check -- python -m pytest providers/fab/tests/unit/fab/auth_manager/views/test_auth_oauth.py -q

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Cursor (GPT-5.3) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Restore the oauth-authorized route on CustomAuthOAuthView so URL building succeeds when FAB overrides AuthOAuthView. Add a regression test to ensure the callback endpoint remains registered.

Co-authored-by: Cursor <cursoragent@cursor.com>
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 18, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@tschroeder-zendesk tschroeder-zendesk changed the title fix(providers/fab): expose oauth_authorized route on CustomAuthOAuthView fix(providers/fab): restore OAuth callback route exposure Feb 19, 2026
@tschroeder-zendesk
Copy link
Author

Superseded by #62151 due to stale PR head not updating after branch history rewrite. Please review #62151 for the same fix with the correct current diff.

@tschroeder-zendesk
Copy link
Author

Closing in favor of #62151 (same fix, correct updated diff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FAB] Invalid OAuth login with airflow-providers-fab==3.3.0

1 participant

Comments