[AIRFLOW-5529] support apache drill hook#6234
Conversation
There was a problem hiding this comment.
I'm not sure if it's a good idea to introduce dependency in such a way.
There was a problem hiding this comment.
I need to use this repository, Unfortunately, this repository does not exist on PYPI packages repository
There was a problem hiding this comment.
Then this PR can't be accepted in to Airflow.
There was a problem hiding this comment.
Because of using none PIPY package?
There was a problem hiding this comment.
This is to ensure that each release/version can run stably & would not be broken because of dependency.
Believe you can understand @blcksrx . I would suggest to close this PR first & re-open it once you address this essential 'issue'. Thanks for the contribution though, and we would be happy to take another look when you make it ready.
There was a problem hiding this comment.
You are Right. Unfortunately, the repo is not active and I' will close it. thanks.
There was a problem hiding this comment.
Why two connections with the same id are merged here
There was a problem hiding this comment.
Ah, Sorry. I will fix it soon.
There was a problem hiding this comment.
Such a docstring may not be info-rich enough and seems typo inside.
There was a problem hiding this comment.
I will improve it but I did write it by comparing with presto_hook. I will add example on it.
|
@XD-DENG I didn't get why it should failed on |
|
@blcksrx it failed because: |
Make sure you have checked all steps below.
Jira
Description
Support Apache Drill hook
Tests
Commits
Documentation