Skip to content

[AIRFLOW-5585] Remove docker context from build#6239

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-docker-context
Oct 4, 2019
Merged

[AIRFLOW-5585] Remove docker context from build#6239
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-docker-context

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 2, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested a review from mik-laj October 2, 2019 14:59
@kaxil kaxil force-pushed the master branch 2 times, most recently from 558f9f1 to d719e1f Compare October 2, 2019 15:30
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #6239 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6239      +/-   ##
==========================================
- Coverage   80.06%   79.71%   -0.36%     
==========================================
  Files         610      610              
  Lines       35261    35441     +180     
==========================================
+ Hits        28231    28251      +20     
- Misses       7030     7190     +160
Impacted Files Coverage Δ
airflow/executors/sequential_executor.py 47.61% <0%> (-52.39%) ⬇️
airflow/contrib/utils/sendgrid.py 68.91% <0%> (-19.02%) ⬇️
airflow/models/baseoperator.py 79.08% <0%> (-16.2%) ⬇️
airflow/utils/log/colored_log.py 81.81% <0%> (-11.37%) ⬇️
airflow/utils/sqlalchemy.py 86.44% <0%> (-6.78%) ⬇️
airflow/executors/__init__.py 63.26% <0%> (-4.09%) ⬇️
airflow/utils/dag_processing.py 54.13% <0%> (-2.59%) ⬇️
airflow/jobs/scheduler_job.py 73.19% <0%> (-1.21%) ⬇️
airflow/models/taskinstance.py 93.24% <0%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d719e1f...8d1bd7c. Read the comment docs.

@potiuk potiuk force-pushed the remove-docker-context branch from 07cfdbc to 8d1bd7c Compare October 2, 2019 19:31
@potiuk potiuk merged commit bf4cea0 into apache:master Oct 4, 2019
potiuk added a commit that referenced this pull request Oct 4, 2019
ashb pushed a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants