Open
Conversation
1 task
jscheffl
approved these changes
Feb 25, 2026
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Technical approval, will merge once a language expert approves.
Contributor
|
I assume we can ignore CI errors here. |
jscheffl
reviewed
Feb 25, 2026
Comment on lines
+164
to
+172
| "partitionedDagRun": "Execució de Dag particionat", | ||
| "partitionedDagRun_one": "{{count}} execució de Dag particionat", | ||
| "partitionedDagRun_other": "{{count}} execucions de Dag particionats", | ||
| "partitionedDagRunDetail": { | ||
| "receivedAssetEvents": "Esdeveniments d'Asset rebuts" | ||
| }, | ||
| "pendingDagRun": "Execució de Dag pendent", | ||
| "pendingDagRun_one": "{{count}} execució de Dag pendent", | ||
| "pendingDagRun_other": "{{count}} execucions de Dag pendents", |
Contributor
There was a problem hiding this comment.
Note: I suspect there is a "bug" in English translation keys, see: #62488
Contributor
There was a problem hiding this comment.
In detail: _one should be the singular phrasing, _other the plural. The key w/o suffix should be removed.
Suggested change
| "partitionedDagRun": "Execució de Dag particionat", | |
| "partitionedDagRun_one": "{{count}} execució de Dag particionat", | |
| "partitionedDagRun_other": "{{count}} execucions de Dag particionats", | |
| "partitionedDagRunDetail": { | |
| "receivedAssetEvents": "Esdeveniments d'Asset rebuts" | |
| }, | |
| "pendingDagRun": "Execució de Dag pendent", | |
| "pendingDagRun_one": "{{count}} execució de Dag pendent", | |
| "pendingDagRun_other": "{{count}} execucions de Dag pendents", | |
| "partitionedDagRun_one": "{{count}} execució de Dag particionat", | |
| "partitionedDagRun_other": "{{count}} execucions de Dag particionats", | |
| "partitionedDagRunDetail": { | |
| "receivedAssetEvents": "Esdeveniments d'Asset rebuts" | |
| }, | |
| "pendingDagRun_one": "{{count}} execució de Dag pendent", | |
| "pendingDagRun_other": "{{count}} execucions de Dag pendents", |
Not an language expert but I assume from interpretation, just deleting the two keys w/o suffix is correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Catalan translations to 100% in main branch.
@oscarhernandezrodriguez can you review it please?
Backported in #62477
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.