Skip to content

Add ingress deprecation warnings for apiServer, statsd, and pgbouncer#62490

Merged
jedcunningham merged 1 commit intoapache:mainfrom
astronomer:chart_ingress_deprecation_warnings
Feb 26, 2026
Merged

Add ingress deprecation warnings for apiServer, statsd, and pgbouncer#62490
jedcunningham merged 1 commit intoapache:mainfrom
astronomer:chart_ingress_deprecation_warnings

Conversation

@jedcunningham
Copy link
Member

Add deprecation warnings in Helm chart NOTES.txt for renamed ingress fields: apiServer.host, apiServer.tls, statsd.host, and pgbouncer.host. All warnings are guarded behind their respective ingress enabled flags to avoid false positives on default installs.

Test Case Values Set Result
apiServer host ingress.apiServer.enabled=true, ingress.apiServer.host=example.com Shows apiServer.host warning
apiServer tls ingress.apiServer.enabled=true, ingress.apiServer.tls.enabled=true Shows apiServer.tls warning
statsd host statsd.enabled=true, ingress.statsd.enabled=true, ingress.statsd.host=statsd.example.com Shows statsd.host warning
pgbouncer host pgbouncer.enabled=true, ingress.pgbouncer.enabled=true, ingress.pgbouncer.host=pgbouncer.example.com Shows pgbouncer.host warning
legacy ingress.enabled ingress.enabled=true, ingress.apiServer.host=api.example.com, ingress.apiServer.tls.enabled=true Shows both apiServer warnings (plus existing web/flower warnings)
No deprecated fields (defaults only) (none) No warnings
apiServer enabled, no deprecated fields ingress.apiServer.enabled=true No warnings
statsd enabled, no deprecated fields statsd.enabled=true, ingress.statsd.enabled=true No warnings

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Cursor CLI

Add deprecation warnings in Helm chart NOTES.txt for renamed ingress
fields: apiServer.host, apiServer.tls, statsd.host, and pgbouncer.host.
All warnings are guarded behind their respective ingress enabled flags
to avoid false positives on default installs.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how did we miss this?!?

@jscheffl jscheffl added this to the Airflow Helm Chart 1.20.0 milestone Feb 26, 2026
@jedcunningham jedcunningham merged commit 00c69f5 into apache:main Feb 26, 2026
77 of 78 checks passed
@jedcunningham jedcunningham deleted the chart_ingress_deprecation_warnings branch February 26, 2026 21:01
AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…apache#62490)

Add deprecation warnings in Helm chart NOTES.txt for renamed ingress
fields: apiServer.host, apiServer.tls, statsd.host, and pgbouncer.host.
All warnings are guarded behind their respective ingress enabled flags
to avoid false positives on default installs.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…apache#62490)

Add deprecation warnings in Helm chart NOTES.txt for renamed ingress
fields: apiServer.host, apiServer.tls, statsd.host, and pgbouncer.host.
All warnings are guarded behind their respective ingress enabled flags
to avoid false positives on default installs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants