Refactor: extract bundle lifecycle helpers and refresh predicate#62517
Open
ephraimbuddy wants to merge 2 commits intoapache:mainfrom
Open
Refactor: extract bundle lifecycle helpers and refresh predicate#62517ephraimbuddy wants to merge 2 commits intoapache:mainfrom
ephraimbuddy wants to merge 2 commits intoapache:mainfrom
Conversation
ephraimbuddy
force-pushed
the
refactor-stale-cleanup
branch
from
9180b2c to
4104edd
Compare
Nataneljpwd
reviewed
Feb 26, 2026
Contributor
Nataneljpwd
left a comment
Nataneljpwd
left a comment
There was a problem hiding this comment.
Looks good, added a few questions
- Move bundle sync and bundle discovery/filtering into dedicated manager methods (sync_bundles, get_all_bundles) and keep run() focused on orchestration. - Route stale bundle version cleanup through cleanup_stale_bundle_versions() instead of inline side effects. - extract the should_refresh_bundle method from _refresh_dag_bundles to make it possible to override the refresh condition without overriding _refresh_dag_bundles - Add unit tests to verify delegation paths and preserve existing behavior.
ephraimbuddy
force-pushed
the
refactor-stale-cleanup
branch
from
4104edd to
57d809f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
methods (sync_bundles, get_all_bundles) and keep run() focused on orchestration.
instead of inline side effects.
it possible to override the refresh condition without overriding _refresh_dag_bundles
Was generative AI tooling used to co-author this PR?
gpt-5.3-codex for tests