Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 3, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5592
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj changed the title [AIRFLOW-5592] Add lint for operators-and-hooks-ref.rst [AIRFLOW-5592][depends on #6249] Add lint for operators-and-hooks-ref.rst Oct 3, 2019
@mik-laj mik-laj requested a review from feluelle October 3, 2019 23:45
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #6255 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6255      +/-   ##
==========================================
- Coverage   80.06%   80.06%   -0.01%     
==========================================
  Files         610      610              
  Lines       35261    35261              
==========================================
- Hits        28232    28231       -1     
- Misses       7029     7030       +1
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 56.72% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3731b1...afce85a. Read the comment docs.

@feluelle feluelle requested a review from potiuk October 4, 2019 09:14
@feluelle
Copy link
Member

feluelle commented Oct 4, 2019

@mik-laj The logic for finding those files looks good imo. But I am not an expert in bash so I would like to have Jarek take another look since he did so much bash recently.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :).

@mik-laj mik-laj changed the title [AIRFLOW-5592][depends on #6249] Add lint for operators-and-hooks-ref.rst [AIRFLOW-5592] Add lint for operators-and-hooks-ref.rst Oct 4, 2019
@mik-laj mik-laj merged commit 104a151 into apache:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants