P1/630p1 add cli api server arg parsing tests#62552
Open
raghuvn97 wants to merge 2 commits intoapache:mainfrom
Open
P1/630p1 add cli api server arg parsing tests#62552raghuvn97 wants to merge 2 commits intoapache:mainfrom
raghuvn97 wants to merge 2 commits intoapache:mainfrom
Conversation
added 2 commits
February 26, 2026 19:52
Add 22 unit tests verifying that the api-server CLI subcommand correctly parses --port, --workers, --apps, --host, --worker-timeout, --proxy-headers, --dev, --ssl-cert, --ssl-key, and --log-config flags. Tests also verify that non-integer values for numeric flags are rejected by the parser. Includes parametrized combinations for regression safety. Closes #1 Made-with: Cursor
Made-with: Cursor
AkshayArali
deleted the
p1/630p1-add-cli-api-server-arg-parsing-tests
branch
Contributor
SameerMesiah97
left a comment
SameerMesiah97
left a comment
There was a problem hiding this comment.
Looks good but let's wait for CI to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1/630p1 add cli api server arg parsing tests