Open
Conversation
We need to get the ti details object so we can get the context carrier, so that we can open the span. This small adjustment lets us get the ti details message separately from the rest of startup, which will make it clean to enclose all of it in a span.
This comment was marked as spam.
This comment was marked as spam.
ashb
approved these changes
Feb 27, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ashb surely satire... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small one in preparation for adding a span around task execution including startup.
We can't create a span until we have the ti details. So it is cleaner if we get the details first, separately from the rest of startup (e.g. parsing the dag), so that we can enclose that part in a span.