Skip to content

[AIRFLOW-XXX] Example for BigQuery to BigQuery operator#6259

Closed
sann3 wants to merge 2 commits intoapache:masterfrom
sann3:master
Closed

[AIRFLOW-XXX] Example for BigQuery to BigQuery operator#6259
sann3 wants to merge 2 commits intoapache:masterfrom
sann3:master

Conversation

@sann3
Copy link
Contributor

@sann3 sann3 commented Oct 4, 2019

Example for BigQuery to BigQuery operator.

Accommodated all the changes mentioned here

@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #6259 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6259      +/-   ##
==========================================
+ Coverage   80.05%   80.07%   +0.01%     
==========================================
  Files         610      611       +1     
  Lines       35264    35270       +6     
==========================================
+ Hits        28232    28241       +9     
+ Misses       7032     7029       -3
Impacted Files Coverage Δ
...rflow/example_dags/example_bigquery_to_bigquery.py 100% <100%> (ø)
airflow/utils/dag_processing.py 56.55% <0%> (-0.35%) ⬇️
airflow/bin/cli.py 66.38% <0%> (+0.2%) ⬆️
airflow/operators/bigquery_to_bigquery.py 100% <0%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76fe45e...f23de31. Read the comment docs.

@mik-laj mik-laj added provider:google Google (including GCP) related issues invalid and removed invalid labels Oct 4, 2019
@sann3
Copy link
Contributor Author

sann3 commented Oct 16, 2019

Is anything pending from my side?

@mik-laj
Copy link
Member

mik-laj commented Oct 16, 2019

Personally, I would prefer all examples for GCP to have system tests
#6227 (comment)

After that, an example for this operator is already in the repository.
https://github.com/apache/airflow/blob/master/airflow/gcp/example_dags/example_bigquery.py#L159-L163
This example has system tests.

@mik-laj
Copy link
Member

mik-laj commented Oct 16, 2019

This change must also have a ticket
#6227 (comment)

@stale
Copy link

stale bot commented Dec 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 4, 2019
@stale stale bot closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants