Skip to content

Comments

[AIRFLOW-5599] Improve Python 3 support in MLEngine integration#6262

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-5599
Oct 7, 2019
Merged

[AIRFLOW-5599] Improve Python 3 support in MLEngine integration#6262
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-5599

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 4, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5599
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #6262 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6262   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files         610      610           
  Lines       35264    35264           
=======================================
  Hits        28232    28232           
  Misses       7032     7032
Impacted Files Coverage Δ
airflow/gcp/utils/mlengine_prediction_summary.py 0% <0%> (ø) ⬆️
airflow/gcp/utils/mlengine_operator_utils.py 95.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fd2af...9134958. Read the comment docs.

@mik-laj mik-laj merged commit 105079e into apache:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants