Fix: Handle MySQL emoji encoding error (1366) in DAG code insertion#62693
Open
MonsterChenzhuo wants to merge 1 commit intoapache:mainfrom
Open
Fix: Handle MySQL emoji encoding error (1366) in DAG code insertion#62693MonsterChenzhuo wants to merge 1 commit intoapache:mainfrom
MonsterChenzhuo wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of database errors when persisting DAG source code, specifically addressing the issue where emoji or other unsupported characters in DAG files cause MySQLdb.OperationalError (1366) on databases with utf8 charset.
Previously, the INSERT INTO dag_code operation was deferred and triggered during the subsequent FAB permission sync ( session.commit() ). This caused the error to be caught by FAB's internal error handler (logged as "Creation of Permission View Error") instead of being handled as a DAG serialization error. As a result, the parsing loop would fail without reporting a visible ImportError to the user.
Changes:
Effect display

Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.