Skip to content

Fix missing timeout in OpenFaasHook and replace bare print in KafkaConsumerHook#62727

Closed
Ironankit525 wants to merge 1 commit intoapache:mainfrom
Ironankit525:fix-openfaas-kafka-issues
Closed

Fix missing timeout in OpenFaasHook and replace bare print in KafkaConsumerHook#62727
Ironankit525 wants to merge 1 commit intoapache:mainfrom
Ironankit525:fix-openfaas-kafka-issues

Conversation

@Ironankit525
Copy link

This pull request submits two minor bug fixes:

  1. Adding timeout parameter to requests API calls in OpenFaasHook.
  2. Replacing a bare print with a logger in KafkaConsumerHook error_callback.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 2, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Mar 2, 2026

The two issues are not related one to another. Please split it to two separated PRs

@Ironankit525
Copy link
Author

The two issues are not related one to another. Please split it to two separated PRs

Thank you for pointing that out. I’ll split the changes and raise two separate PRs accordingly.

@Ironankit525
Copy link
Author

Closing this PR as requested by the maintainer. Splitting into two separate PRs.

@Ironankit525 Ironankit525 deleted the fix-openfaas-kafka-issues branch March 2, 2026 20:28
@eladkal
Copy link
Contributor

eladkal commented Mar 2, 2026

Closing this PR as requested by the maintainer. Splitting into two separate PRs.

You can also convert this one to handle one of them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants