Add timeout to requests API calls in OpenFaasHook#62731
Open
Ironankit525 wants to merge 1 commit intoapache:mainfrom
Open
Add timeout to requests API calls in OpenFaasHook#62731Ironankit525 wants to merge 1 commit intoapache:mainfrom
Ironankit525 wants to merge 1 commit intoapache:mainfrom
Conversation
All HTTP requests in OpenFaasHook (get, post, put) now include a configurable timeout parameter (default 60s) read from the connection extra dict. Without a timeout, an unresponsive server could cause Airflow tasks to hang indefinitely, tying up worker slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened:
The
OpenFaasHookmakes several outgoing HTTP requests to the OpenFaaS server using therequestslibrary (requests.post,requests.put,requests.get). None of these requests currently specify atimeoutargument.Without a timeout, an unresponsive OpenFaaS server could cause an Airflow task to hang indefinitely, tying up worker slots.
Fix:
All
requestscalls inOpenFaasHooknow include a configurabletimeoutparameter (default 60 seconds), read from the connection'sextradictionary. Users can override the timeout via the connection configuration.