Replace print() with proper logger in KafkaConsumerHook error_callback#62732
Open
Ironankit525 wants to merge 2 commits intoapache:mainfrom
Open
Replace print() with proper logger in KafkaConsumerHook error_callback#62732Ironankit525 wants to merge 2 commits intoapache:mainfrom
Ironankit525 wants to merge 2 commits intoapache:mainfrom
Conversation
The error_callback function in KafkaConsumerHook was using a bare print() statement for non-authentication Kafka errors. This bypasses Airflow's logging infrastructure, making errors invisible to log aggregation and alerting systems. Replaced with logging.getLogger to ensure consistent, structured error reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened:
In
airflow/providers/apache/kafka/src/airflow/providers/apache/kafka/hooks/consume.py, theerror_callbackfunction handles errors fromconfluent_kafka. For non-authentication errors, it uses a bareprint()statement, which bypasses Airflow's logging infrastructure.Fix:
Replaced
print("Exception received: ", err)withlog.error("Exception received from Kafka: %s", err)using a module-levellogging.getLogger(__name__). This ensures errors are properly captured by Airflow's logging handlers and log aggregation systems.