[v3-1- test] Scope session token in cookie to base_url (#62771)#62851
[v3-1- test] Scope session token in cookie to base_url (#62771)#62851vatsrahul1001 merged 2 commits intov3-1-testfrom
Conversation
jason810496
left a comment
There was a problem hiding this comment.
The airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/login/Login.tsx and airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/queryClient.ts need to backport manual as well, otherwise LGTM.
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/routes/login.py
Show resolved
Hide resolved
jason810496
left a comment
There was a problem hiding this comment.
The UI changes are separated from this PR because they require a UI bump in v3-1-test, so we’ll merge this PR first.
Then we need to merge:
Thanks!
|
There are some conflicts and looks like a lot of commits ? Posibly something wrong when backportint? |
* Scope session token in cookie to base_url * Make get_cookie_path import backwards compatible (cherry picked from commit 43ee8c4)
e7e1a6b to
5165e42
Compare
Yeah branch had accumulated unrelated commits because it diverged from v3-1-test. I have fixed now |
|
The two backport linked contains 150+ commits and are not in a reviewable state. |
Yeah same issue as #62851 (comment). I have asked @jason810496 to rebase |
jason810496
left a comment
There was a problem hiding this comment.
The two backport linked contains 150+ commits and are not in a reviewable state.
I just fixed both one, thanks for the reminder.
Backport of #62771
Scope session token in cookie to base_url
Make get_cookie_path import backwards compatible
(cherry picked from commit 43ee8c4)
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.