Skip to content

[v3-1- test] Scope session token in cookie to base_url (#62771)#62851

Merged
vatsrahul1001 merged 2 commits intov3-1-testfrom
backport-62771
Mar 5, 2026
Merged

[v3-1- test] Scope session token in cookie to base_url (#62771)#62851
vatsrahul1001 merged 2 commits intov3-1-testfrom
backport-62771

Conversation

@vatsrahul1001
Copy link
Contributor

Backport of #62771

  • Scope session token in cookie to base_url

  • Make get_cookie_path import backwards compatible

(cherry picked from commit 43ee8c4)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/login/Login.tsx and airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/queryClient.ts need to backport manual as well, otherwise LGTM.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI changes are separated from this PR because they require a UI bump in ‎v3-1-test, so we’ll merge this PR first.

Then we need to merge:

  • Bump UI dependencies: #62858
  • Backport the UI changes in: #62859

cc @pierrejeambrun

Thanks!

@potiuk
Copy link
Member

potiuk commented Mar 4, 2026

There are some conflicts and looks like a lot of commits ? Posibly something wrong when backportint?

wolfdn and others added 2 commits March 4, 2026 19:50
* Scope session token in cookie to base_url

* Make get_cookie_path import backwards compatible

(cherry picked from commit 43ee8c4)
@vatsrahul1001
Copy link
Contributor Author

There are some conflicts and looks like a lot of commits ? Posibly something wrong when backportint?

Yeah branch had accumulated unrelated commits because it diverged from v3-1-test. I have fixed now

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Mar 4, 2026

The two backport linked contains 150+ commits and are not in a reviewable state.

@vatsrahul1001
Copy link
Contributor Author

The two backport linked contains 150+ commits and are not in a reviewable state.

Yeah same issue as #62851 (comment). I have asked @jason810496 to rebase

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two backport linked contains 150+ commits and are not in a reviewable state.

I just fixed both one, thanks for the reminder.

@vatsrahul1001 vatsrahul1001 merged commit 9b9dc13 into v3-1-test Mar 5, 2026
87 checks passed
@vatsrahul1001 vatsrahul1001 deleted the backport-62771 branch March 5, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:providers kind:documentation provider:amazon AWS/Amazon - related issues provider:fab provider:keycloak type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants