Add toolset design guidance to common AI AGENTS.md#62870
Merged
kaxil merged 1 commit intoapache:mainfrom Mar 4, 2026
Merged
Conversation
The existing AGENTS.md covers hooks and operators but doesn't mention toolsets. As we add more toolset backends (DataFusion, etc.) alongside the existing SQLToolset, having clear guidance upfront will help contributors follow consistent patterns. Adds: - "One backend per toolset" design principle - "Adding a New Toolset" section with the four-tool pattern and constructor hygiene guidelines - Toolsets path in Key Paths
1Ninad
pushed a commit
to 1Ninad/airflow
that referenced
this pull request
Mar 6, 2026
The existing AGENTS.md covers hooks and operators but doesn't mention toolsets. As we add more toolset backends (DataFusion, etc.) alongside the existing SQLToolset, having clear guidance upfront will help contributors follow consistent patterns. Adds: - "One backend per toolset" design principle - "Adding a New Toolset" section with the four-tool pattern and constructor hygiene guidelines - Toolsets path in Key Paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
AGENTS.mdfor the common AI provider covers hooks and operators but has no guidance for toolsets. As we start adding more toolset backends alongsideSQLToolset, contributors need a clear pattern to follow.This adds:
AgentOperator(toolsets=[...]).list_tables,get_schema,query,check_query), shared helper extraction, constructor hygiene (no silently-ignored params), andsequential=Trueguidance.Why now
With DataFusion and other backends on the horizon, having this guidance upfront keeps new toolset PRs consistent and avoids dual-mode classes that branch on constructor params.