Remove astroid<4 pin now that sphinx-autoapi>=3.6.1 supports astroid 4#62894
Closed
ShubhamGondane wants to merge 1 commit intoapache:mainfrom
Closed
Remove astroid<4 pin now that sphinx-autoapi>=3.6.1 supports astroid 4#62894ShubhamGondane wants to merge 1 commit intoapache:mainfrom
ShubhamGondane wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
I don't think this will work. I think we need |
Author
|
@eladkal Thank you for pointing that out! I wasn't aware of that commit. This is my first time contributing to an open source project and I'm still learning how to navigate upstream dependencies. I'll close this PR for now and we can revisit once sphinx-autoapi commit is released. |
Contributor
|
@ShubhamGondane you can always check with upstream library what is the status and when they release reopen this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sphinx-autoapi 3.6.1 (released Oct 2025) added support for astroid 4 by fixing the breaking
AstroidBuilderchange. Theastroid<4workaround pin is no longer needed.closes: #56420