Skip to content

Add template_fields to SalesforceBulkOperator#62908

Open
neooooo28 wants to merge 2 commits intoapache:mainfrom
neooooo28:add-template-fields-salesforce-bulk-operator
Open

Add template_fields to SalesforceBulkOperator#62908
neooooo28 wants to merge 2 commits intoapache:mainfrom
neooooo28:add-template-fields-salesforce-bulk-operator

Conversation

@neooooo28
Copy link

Summary

  • Adds template_fields to SalesforceBulkOperator so Jinja templating works on operation, object_name, payload, and external_id_field parameters
  • Adds a test to verify the template_fields tuple is defined correctly
  • Follows the same pattern used across other Airflow operators

Closes #62375

Test plan

  • Added unit test verifying template_fields tuple contents
  • Existing Salesforce provider tests pass without modification

🤖 Generated with Claude Code

Add template_fields support for operation, object_name, payload, and
external_id_field parameters so that Jinja templating works correctly
with the SalesforceBulkOperator.

Closes: apache#62375

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 5, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Add template_fields to enable Jinja templating for endpoint, method,
and payload parameters. Expand test coverage from 1 test to 8, covering
all HTTP methods (GET, PUT, DELETE, PATCH), default method verification,
xcom push disabled behavior, and template_fields validation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add template_fields support to SalesforceBulkOperator

1 participant