Skip to content

Enable Elasticsearch provider integration tests in CI#62942

Merged
jason810496 merged 3 commits intoapache:mainfrom
Owen-CH-Leung:chore/enable_es_integration_test
Mar 6, 2026
Merged

Enable Elasticsearch provider integration tests in CI#62942
jason810496 merged 3 commits intoapache:mainfrom
Owen-CH-Leung:chore/enable_es_integration_test

Conversation

@Owen-CH-Leung
Copy link
Contributor

@Owen-CH-Leung Owen-CH-Leung commented Mar 5, 2026

elasticsearch was explicitly listed in DISABLE_TESTABLE_INTEGRATIONS_FROM_CI. This meant the test was never run in CI.

Fix

  • Create a proper integration test at providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py that uses the Breeze ES service (http://elasticsearch:9200) directly - the same pattern used by Mongo
    and Redis providers.
  • Move tests that involves IO with elasticsearch to integration test
  • Remove the now-unused testcontainers fixture pyproject.toml.
  • Remove elasticsearch from DISABLE_TESTABLE_INTEGRATIONS_FROM_CI so the integration test runs as a separate CI job whenever the Elasticsearch provider is affected.

@Owen-CH-Leung Owen-CH-Leung changed the title feat(elasticsearch): enable integration test Enable Elasticsearch provider integration tests in CI Mar 5, 2026
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Owen for the follow-up!

FAILED tests/test_selective_checks.py::test_expected_output_pull_request_main[All tests should be run when devel-common/ change] - AssertionError: Correct value for 'testable-providers-integrations'
assert "['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']" == "['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']"
  
  - ['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
  + ['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
  ?                                 +++++++++++++++++

LGTM overall, the only CI failure comes from:

"testable-providers-integrations": "['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', "

@Owen-CH-Leung Owen-CH-Leung marked this pull request as draft March 6, 2026 07:59
@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review March 6, 2026 10:44
@Owen-CH-Leung
Copy link
Contributor Author

Thanks Owen for the follow-up!

FAILED tests/test_selective_checks.py::test_expected_output_pull_request_main[All tests should be run when devel-common/ change] - AssertionError: Correct value for 'testable-providers-integrations'
assert "['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']" == "['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']"
  
  - ['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
  + ['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
  ?                                 +++++++++++++++++

LGTM overall, the only CI failure comes from:

"testable-providers-integrations": "['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', "

Thanks Jason. It's fixed now.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for aligning the ES integration test architecture with rest of the integration tests.

@jason810496 jason810496 removed the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Mar 6, 2026
@jason810496
Copy link
Member

jason810496 commented Mar 6, 2026

It's test only PR for provider with no dependencies upgrade so we don't need to backport.

@jason810496 jason810496 merged commit e76becd into apache:main Mar 6, 2026
258 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants