Enable Elasticsearch provider integration tests in CI#62942
Merged
jason810496 merged 3 commits intoapache:mainfrom Mar 6, 2026
Merged
Enable Elasticsearch provider integration tests in CI#62942jason810496 merged 3 commits intoapache:mainfrom
jason810496 merged 3 commits intoapache:mainfrom
Conversation
9af7c0b to
b0563b0
Compare
jason810496
reviewed
Mar 6, 2026
Member
jason810496
left a comment
There was a problem hiding this comment.
Thanks Owen for the follow-up!
FAILED tests/test_selective_checks.py::test_expected_output_pull_request_main[All tests should be run when devel-common/ change] - AssertionError: Correct value for 'testable-providers-integrations'
assert "['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']" == "['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']"
- ['celery', 'cassandra', 'drill', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
+ ['celery', 'cassandra', 'drill', 'elasticsearch', 'tinkerpop', 'kafka', 'mongo', 'pinot', 'qdrant', 'redis', 'trino', 'ydb']
? +++++++++++++++++
LGTM overall, the only CI failure comes from:
airflow/dev/breeze/tests/test_selective_checks.py
Line 1124 in da4ce85
Contributor
Author
Thanks Jason. It's fixed now. |
jason810496
approved these changes
Mar 6, 2026
Member
|
It's test only PR for provider with no dependencies upgrade so we don't need to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elasticsearchwas explicitly listed inDISABLE_TESTABLE_INTEGRATIONS_FROM_CI. This meant the test was never run in CI.Fix
providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.pythat uses the Breeze ES service (http://elasticsearch:9200) directly - the same pattern used by Mongoand Redis providers.
elasticsearchto integration testtestcontainersfixture pyproject.toml.elasticsearchfromDISABLE_TESTABLE_INTEGRATIONS_FROM_CIso the integration test runs as a separate CI job whenever the Elasticsearch provider is affected.