fix: clean up Docker resources after executing commands in Breeze#62992
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 6, 2026
Merged
fix: clean up Docker resources after executing commands in Breeze#62992potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Backport failed to create: v3-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 27c11d0 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
breeze runleaking a Docker network on every invocationEach
breeze runcreates a unique compose project (breeze-run-<uuid>) but never tears it down afterward. The--rmflag ondocker compose runremoves the container but not the network.Over time, stale networks accumulate and Docker's IPAM exhausts its default address pool. In my case, it ended with docker Docker allocate an ip identical to my wifi router's IP. This created a bridge interface that captured traffic meant for the real gateway, silently breaking all my IPv4 connectivity.
My implementation wrap the command execution in
try/finallyand callbring_compose_project_down+remove_docker_networks, matching the existing pattern intesting_commands.py.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.6) following the guidelines