Updates exception to hide sql statements on constraint failure#63028
Open
aritra24 wants to merge 5 commits intoapache:mainfrom
Open
Updates exception to hide sql statements on constraint failure#63028aritra24 wants to merge 5 commits intoapache:mainfrom
aritra24 wants to merge 5 commits intoapache:mainfrom
Conversation
The exception handler now hides the sql statement when the expose stacktrace flag is false.
aritra24
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
potiuk
approved these changes
Mar 7, 2026
Member
|
Some test failures :( |
Collaborator
Author
|
Ah shoot, i thought I'd fixed all of them. I'm away until the morning, will push a fix then |
Since pytest returns a starlette HTTPException it annotates details as a string, we make use of FastApi's HTTPException which returns details as a dict. Due to this mypy get's confused about some of the operations we're performing on a dict.
Collaborator
Author
|
Looks like unrelated failures, so merged main in to see if they're older issues already fixed |
Collaborator
Author
|
Hmm, the test looks unrelated to my change.... @potiuk would you be able to retrigger the failed job if you get some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception handler now hides the sql statement when the expose stacktrace flag is false.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.