Add missing HTTP timeout to FAB JWKS fetching#63058
Merged
vincbeck merged 1 commit intoapache:mainfrom Mar 9, 2026
Merged
Conversation
Adds a 30s timeout to JWKS request (from Authentik or Microsoft) to prevent indefinite hangs. This is a network call for auth metadata which should fail fast if the remote server is unresponsive.
SameerMesiah97
approved these changes
Mar 8, 2026
Contributor
SameerMesiah97
left a comment
SameerMesiah97
left a comment
There was a problem hiding this comment.
Looks good to me.
vincbeck
approved these changes
Mar 9, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 30s timeout to
requests.getcalls in the FAB security manager override when fetching JSON Web Key Sets (JWKS) from Authentik or Microsoft.Justification:
Fetching JWKS is a fast metadata operation. If the remote server hangs, it will block the authentication process indefinitely, consuming worker resources. A 30-second timeout ensures it fails fast.
Split from #63042 and closes #63033.