Skip to content

Refine SKILL.md for airflow-translation agent skill#63060

Merged
potiuk merged 1 commit intoapache:mainfrom
sjyangkevin:refine-airflow-translations-skill-md
Mar 7, 2026
Merged

Refine SKILL.md for airflow-translation agent skill#63060
potiuk merged 1 commit intoapache:mainfrom
sjyangkevin:refine-airflow-translations-skill-md

Conversation

@sjyangkevin
Copy link
Contributor

related: #61984

Why

Adds more clarity and make the instruction more like actionable steps. The previous instruction looks more like a document reference, and only a small section instructs the step-by-step workflow. However, the workflow can be different between adding a new translation and maintaining an existing translation. The updated instruction enhance the clarity, and provide step-by-step guideline on how to proceed with each task.

Added an example showing exactly what the scaffolded files will look like (e.g., "allRuns": "TODO: translate: All Runs"). This makes it more clear what the agent is supposed to look for and edit.

Moved reference material, such as the General Translation Rules, Terms Kept in English, and Plural Forms, below the workflow steps. Previously, an agent had to read through all the theoretical rules before figuring out what actually needed to be done. Now, the context is provided as reference material precisely when it's needed. Also, these rules may be override in locale-specific instruction; the phrasing also refined to make the instruction more clear when should follow the locale-specific guideline.

Added a validation step, to instruct running the completion check and prek command


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Antigravity] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Mar 7, 2026
@sjyangkevin sjyangkevin marked this pull request as ready for review March 7, 2026 20:47
@potiuk potiuk merged commit f0a7828 into apache:main Mar 7, 2026
117 checks passed
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker f0a7828 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants