issue-37213: Standardizing FTPToS3Operator#63082
Open
jroachgolf84 wants to merge 1 commit intoapache:mainfrom
Open
issue-37213: Standardizing FTPToS3Operator#63082jroachgolf84 wants to merge 1 commit intoapache:mainfrom
FTPToS3Operator#63082jroachgolf84 wants to merge 1 commit intoapache:mainfrom
Conversation
FTPToS3Operator
Collaborator
Author
|
@vincbeck, do you mind taking a peek at this one? |
vincbeck
reviewed
Mar 9, 2026
Contributor
vincbeck
left a comment
There was a problem hiding this comment.
Those are breaking changes without any deprecation path. I do not think we can move forward with that. We usually first deprecate things, and then remove them
Collaborator
Author
|
Would it be okay to go back and add deprecation for those parameters? |
Contributor
Definitely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per #37213:
The PR refactors the
FTPToS3Operatorto mirror the functionality of theS3ToFTPOperator(it's "inverse" counterpart) andSFTPToS3Operator(it's sibling). This meant removing the ability to move multiple files and sticking with a single-file approach. This matches the behavior of its close relatives and helps to maintain Airflow DAG-authoring best practices.Testing
These changes were tested E2E, as well as with updated unit tests. These unit tests can be run as follows:
closes: #37213