Improve Playwright test patterns in backfill.spec.ts#63112
Merged
choo121600 merged 3 commits intoapache:mainfrom Mar 9, 2026
Merged
Improve Playwright test patterns in backfill.spec.ts#63112choo121600 merged 3 commits intoapache:mainfrom
backfill.spec.ts#63112choo121600 merged 3 commits intoapache:mainfrom
Conversation
stats-dev
force-pushed
the
e2e/63041-improve-backfill-patterns
branch
from
0d65510 to
2363bf7
Compare
Contributor
Author
Thanks for your guidance and helpful feedback! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
backfill.spec.tsandBackfillPage.tsto align with Playwright best practices.page.waitForTimeout()withexpect.poll()toHaveCount()assertionshas-text()withgetByText()user-facing locatorgetTableColumnCount()methodcloses: #63041
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines