Fix access control issue for task group views in DAG UI #63382
Closed
SUCHNA24 wants to merge 1 commit intoapache:mainfrom
Closed
Fix access control issue for task group views in DAG UI #63382SUCHNA24 wants to merge 1 commit intoapache:mainfrom
SUCHNA24 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
What's the PR title: "Issue #59840 was resolved by me"! |
Author
|
Thanks for pointing that out. I apologize for the incorrect PR title. I’m still learning the contribution guidelines and will make sure to use a proper descriptive title in future pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes DAG-level access control for task group views when using FAB-based authorization.
Previously, users with DAG-specific permissions like
can_readonDAG:<dag_id>plus task-related permissions could still get a 404 when accessing task group and grid-related views, unless they were also granted the globalcan_readonDAGs(and oftenDAG Runs). This effectively forced over‑broad permissions just to view per‑DAG task group details.With this change, the authorization logic correctly respects DAG-specific permissions for DAG-scoped sub-entities (task instances, runs, and task groups) so that:
can read DAG:<dag_id>and the relevant task/run permissions can access:/dags/{dag_id}/tasks/group/{group_id})can read DAGsto reach those URLs, so DAG visibility remains restricted to the intended set.The behavior for truly global permissions (e.g. full
DAGsaccess) is unchanged.Testing
/dags/{specific_dag_id}/tasks/group/{group_id}without 404