Fix datafusion import breaking provider yaml validation#63395
Closed
potiuk wants to merge 1 commit intoapache:mainfrom
Closed
Fix datafusion import breaking provider yaml validation#63395potiuk wants to merge 1 commit intoapache:mainfrom
potiuk wants to merge 1 commit intoapache:mainfrom
Conversation
The top-level ``from datafusion.object_store import ...`` in object_storage_provider.py caused provider.yaml validation to fail when the datafusion package was not installed, since importing the analytics operator module transitively triggered this import. Move the imports into the methods that use them so the module can be imported without datafusion installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vincbeck
approved these changes
Mar 11, 2026
Member
|
yeah good to move this but not sure that does fix the issue, because there is session context imported in the |
gopidesupavan
approved these changes
Mar 11, 2026
Member
Author
Let's see :) |
bugraoz93
approved these changes
Mar 11, 2026
Member
Author
|
Yeah. not helping .. @gopidesupavan - yours is better :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
object_storage_provider.pyin thecommon.sqlprovider has top-level imports fromdatafusion.object_storewhich is not a required dependency. This breaks theValidate provider.yaml filesCI check because the module fails to import whendatafusionis not installed.Move the
from datafusion.object_store import AmazonS3andfrom datafusion.object_store import LocalFileSystemimports inside their respectivecreate_object_store()methods where they are actually used, following the lazy-import pattern already used elsewhere in the codebase.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.6) following the guidelines