Skip to content

Improve Playwright test patterns in dag-code-tab.spec.ts #63410#63416

Merged
choo121600 merged 1 commit intoapache:mainfrom
haseebmalik18:fix/e2e-improve-dag-code-tab-tests
Mar 12, 2026
Merged

Improve Playwright test patterns in dag-code-tab.spec.ts #63410#63416
choo121600 merged 1 commit intoapache:mainfrom
haseebmalik18:fix/e2e-improve-dag-code-tab-tests

Conversation

@haseebmalik18
Copy link
Contributor

Improve Playwright test patterns in DagCodePage.ts to align with Playwright best practices.

  • Replace .waitFor() with expect().toBeVisible() web-first assertions
  • Replace manual count assertions with expect().not.toHaveCount(0)
  • Replace textContent() and manual assert with expect().toHaveText()
  • Replace getAttribute() and manual regex with expect().toHaveAttribute()
  • Replace one-shot evaluate() and manual assert with expect.poll() retrying assertion
  • Move inline viewLines locator to class property

closes: #63410

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 12, 2026
Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Cool :)

@choo121600 choo121600 merged commit 7ed94f1 into apache:main Mar 12, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Improve Playwright test patterns in dag-code-tab.spec.ts

2 participants