Skip to content

Add people selection group and reviewer filter to auto-triage#63422

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:auto-triage-people-options
Mar 12, 2026
Merged

Add people selection group and reviewer filter to auto-triage#63422
potiuk merged 1 commit intoapache:mainfrom
potiuk:auto-triage-people-options

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 12, 2026

Summary

  • Group --author, --include-collaborators, --reviews-for-me, --reviews-for into a dedicated
    "Select people" section in the breeze pr auto-triage help output
  • Rename --review-requested to --reviews-for-me for clarity
  • Add --reviews-for option (mutually exclusive with --reviews-for-me) to filter PRs by specific
    reviewer(s), with shell autocomplete from a locally cached collaborators list that is
    refreshed in the background on each command invocation
  • Add HiddenChoiceWithCompletion param type that provides tab-completion without listing
    choices in --help
  • Simplify triage comments posted on collaborator-authored PRs: no emojis, no instruction
    links, no "What to do next" — just the issues

Test plan

  • Run breeze pr auto-triage --help and verify "Select people" group appears with all four options
  • Run breeze pr auto-triage --reviews-for-me --reviews-for someone and verify mutual exclusion error
  • Run breeze pr auto-triage --reviews-for user1 --reviews-for user2 --dry-run and verify multi-reviewer fetch
  • Run breeze pr auto-triage --reviews-for-me --dry-run and verify it filters by authenticated user
  • Verify collaborator cache is created in .build/ after a run
  • Verify --reviews-for tab-completion works after cache is populated

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Opus 4.6

Generated-by: Claude Opus 4.6 following the guidelines

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Mar 12, 2026
@potiuk potiuk force-pushed the auto-triage-people-options branch 2 times, most recently from 2e5f604 to d7c21fd Compare March 12, 2026 11:39
@potiuk
Copy link
Member Author

potiuk commented Mar 12, 2026

Next iteration of auto-triage

@choo121600
Copy link
Member

Wow 🙌

@choo121600
Copy link
Member

choo121600 commented Mar 12, 2026

Small question: “--my-reviews” might be interpreted as reviews that I have written. I actually had the same concern when implementing this feature.

That said, I can’t think of a better alternative right now, so I think the current wording is probably fine.

@potiuk
Copy link
Member Author

potiuk commented Mar 12, 2026

That said, I can’t think of a better alternative right now, so I think the current wording is probably fine.

Yeah. Naming is hard. --reviews-for-me maybe ?

@potiuk
Copy link
Member Author

potiuk commented Mar 12, 2026

And --reviews-for for others.

@potiuk potiuk force-pushed the auto-triage-people-options branch 2 times, most recently from bb6696d to 2fec3c5 Compare March 12, 2026 12:29
@choo121600
Copy link
Member

Yeah, --reviews-for-me and --reviews-for sound much clearer to me 👍

@potiuk potiuk force-pushed the auto-triage-people-options branch from 2fec3c5 to c0e9eab Compare March 12, 2026 13:39
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@potiuk potiuk force-pushed the auto-triage-people-options branch from c0e9eab to a29599d Compare March 12, 2026 13:39
@potiuk potiuk merged commit 4b69954 into apache:main Mar 12, 2026
4 checks passed
@potiuk potiuk deleted the auto-triage-people-options branch March 12, 2026 13:39
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 4b69954 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Pyasma pushed a commit to Pyasma/airflow that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants