[v3-1-test] Fix regression in security iframe navigation logic with basename (#63141)#63453
Open
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Open
[v3-1-test] Fix regression in security iframe navigation logic with basename (#63141)#63453github-actions[bot] wants to merge 1 commit intov3-1-testfrom
github-actions[bot] wants to merge 1 commit intov3-1-testfrom
Conversation
…asename (#63141) * Fix regression in security iframe navigation logic with basename * style: apply formatting to Security.tsx * fix(ui): remove hardcoded localhost fallback from Security iframe navigation * Add newsfragment for security iframe basename fix * Address review feedback: simplify security iframe navigation logic and handle basename (cherry picked from commit 8653aa8) Co-authored-by: Subham <subhamsangwan26@gmail.com>
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression in security iframe navigation logic with basename
style: apply formatting to Security.tsx
fix(ui): remove hardcoded localhost fallback from Security iframe navigation
Add newsfragment for security iframe basename fix
Address review feedback: simplify security iframe navigation logic and handle basename
(cherry picked from commit 8653aa8)
Co-authored-by: Subham subhamsangwan26@gmail.com