Use dedicated exception classes over AirflowException for AGENTS.md#63495
Merged
jason810496 merged 3 commits intoapache:mainfrom Mar 14, 2026
Merged
Use dedicated exception classes over AirflowException for AGENTS.md#63495jason810496 merged 3 commits intoapache:mainfrom
jason810496 merged 3 commits intoapache:mainfrom
Conversation
…ption Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
jason810496
requested review from
amoghrajesh,
ashb,
choo121600,
jscheffl,
kaxil,
potiuk and
shahar1
as code owners
choo121600
approved these changes
Mar 13, 2026
Member
|
Cool :) |
Collaborator
|
Perhaps we should finally do something about #46932 |
potiuk
reviewed
Mar 13, 2026
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
approved these changes
Mar 13, 2026
jscheffl
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As discussed in dev list long time ago, it would be better to use dedicated exception classes instead of too broad AirflowException for the new exceptions.
I catch several similar new exception usage manually during review (e.g. one of the recent one #61550 (comment)), so adding a new rules in AGENTS.md could point out automatically before maintainer review.
Was generative AI tooling used to co-author this PR?